wchevreuil commented on a change in pull request #1174: HBASE-23827 [HBCK2] Add mergeRegions method to hbck service URL: https://github.com/apache/hbase/pull/1174#discussion_r382460076
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ########## @@ -2458,6 +2443,48 @@ public FileArchiveNotificationResponse reportFileArchival(RpcController controll // HBCK Services + @Override + public MergeTableRegionsResponse mergeRegions(RpcController c, MergeTableRegionsRequest request) Review comment: > But shouldn't we be able to determine whether the request is coming in from hbck or regular client? Yeah, that's the main question. My view is that the use case for both are the same, users triggering merges via shell or java API are already performing some sort of advanced admin operation, if those fail then they would just resort to hbck. I think a bit confusing that we provide two methods to do the same thing, only different in the level of extra checks performed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
