saintstack commented on a change in pull request #1186: HBASE-19146 Update
Protobuf to 3.11.4
URL: https://github.com/apache/hbase/pull/1186#discussion_r382926536
##########
File path: pom.xml
##########
@@ -1517,7 +1517,7 @@
<log4j.version>1.2.17</log4j.version>
<mockito-core.version>2.28.2</mockito-core.version>
<!--Internally we use a different version of protobuf. See
hbase-protocol-shaded-->
- <external.protobuf.version>2.5.0</external.protobuf.version>
+ <external.protobuf.version>3.11.4</external.protobuf.version>
Review comment:
Ouch.
Do you get the bit where we use shaded pb3 internally but that unshaded
pb2.5 is available for users? (HBase3/master branch is looking like it will
purge the unshaded pb2.5 usage... but that is another PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
