saintstack commented on a change in pull request #1200: HBASE 23887 BlockCache
performance improve
URL: https://github.com/apache/hbase/pull/1200#discussion_r383668335
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
##########
@@ -299,15 +307,15 @@ public LruBlockCache(long maxSize, long blockSize,
Configuration conf) {
* @param memoryFactor percentage of total size for in-memory blocks
*/
public LruBlockCache(long maxSize, long blockSize, boolean evictionThread,
- int mapInitialSize, float mapLoadFactor, int mapConcurrencyLevel,
- float minFactor, float acceptableFactor, float singleFactor,
- float multiFactor, float memoryFactor, float hardLimitFactor,
- boolean forceInMemory, long maxBlockSize) {
+ int mapInitialSize, float mapLoadFactor, int
mapConcurrencyLevel,
+ float minFactor, float acceptableFactor, float
singleFactor,
+ float multiFactor, float memoryFactor, float
hardLimitFactor,
+ boolean forceInMemory, long maxBlockSize, int
cacheDataBlockPercent) {
Review comment:
Best to leave these sort of refactorings out of your patch. They bulk it up
and distract from what is important about your change. FYI for next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
