pustota2009 commented on a change in pull request #1200: HBASE 23887 BlockCache 
performance improve
URL: https://github.com/apache/hbase/pull/1200#discussion_r383682171
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
 ##########
 @@ -299,15 +307,15 @@ public LruBlockCache(long maxSize, long blockSize, 
Configuration conf) {
    * @param memoryFactor        percentage of total size for in-memory blocks
    */
   public LruBlockCache(long maxSize, long blockSize, boolean evictionThread,
-      int mapInitialSize, float mapLoadFactor, int mapConcurrencyLevel,
-      float minFactor, float acceptableFactor, float singleFactor,
-      float multiFactor, float memoryFactor, float hardLimitFactor,
-      boolean forceInMemory, long maxBlockSize) {
+                       int mapInitialSize, float mapLoadFactor, int 
mapConcurrencyLevel,
+                       float minFactor, float acceptableFactor, float 
singleFactor,
+                       float multiFactor, float memoryFactor, float 
hardLimitFactor,
+                       boolean forceInMemory, long maxBlockSize, int 
cacheDataBlockPercent) {
 
 Review comment:
   Thanks! Will correct soon)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to