[
https://issues.apache.org/jira/browse/HBASE-23889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044197#comment-17044197
]
Duo Zhang commented on HBASE-23889:
-----------------------------------
What I can see is that, after mering back the feature branch, the flaky list
for master branch became really big.
And to be honestly, I do not think it is the correct way to fix all the UTs by
calling an invalidateConnection method, which means I need to get a new
Connection everytime after a master restarts.
I stand my point with switching back to ZK based registry for now. We need to
fnish this TODO
{code}
TODO: Handle changes to the configuration dynamically without having to restart
the client.
{code}
And also, remove the invalidateConnection method in HBTU, just reset the
property in Configuration to let the client load the new configuration
automatically.
Then I'm OK with setting MasterRegistry as default.
> Switch back to ZKConnectionRegistry by default at least in test
> ---------------------------------------------------------------
>
> Key: HBASE-23889
> URL: https://issues.apache.org/jira/browse/HBASE-23889
> Project: HBase
> Issue Type: Bug
> Components: Client, rpc, test
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
>
> For now, MasterRegistry can not deal with master restart, as it can not load
> the new master address automatically.
> I see there is a invalidateConnection method in HBaseTestingUtilities but it
> needs a very big refactoring to make all the UTs work like this.
> So here I suggest we switch back to ZKConnectionRegistry by default, and open
> a new feature branch to finish the TODOs and the refactoring on UTs.
> As now it is already a big problem for me as I want to merge a feature branch
> back to master but the state of UTs are a mess.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
