[ 
https://issues.apache.org/jira/browse/HBASE-23889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045504#comment-17045504
 ] 

Duo Zhang commented on HBASE-23889:
-----------------------------------

In our deployment, we put zookeeper behind a lvs, so it is free for us to 
change the machine for zookeeper, and use do not need to change their 
configurations when zookeeper machines are changed.

But for HMaster, it is another story. It is not easy to put them behind a lvs, 
as we have builtin active and backup master logic in the code of hbase-client, 
not all masters are the same. So if we want to change the machine of a master 
deploy, changing the configuration of all the clients are already a big problem 
but anyway using a central configuration system can partly solve it. But if 
this requires all client to restart then this will be a very very big problem.

Anyway, this has to be done before 3.0.0 release. If we can not finish the 
feature before 3.0.0 release, we have to switch back to zk based registry.

> Switch back to ZKConnectionRegistry by default at least in test
> ---------------------------------------------------------------
>
>                 Key: HBASE-23889
>                 URL: https://issues.apache.org/jira/browse/HBASE-23889
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, rpc, test
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>
> For now, MasterRegistry can not deal with master restart, as it can not load 
> the new master address automatically.
> I see there is a invalidateConnection method in HBaseTestingUtilities but it 
> needs a very big refactoring to make all the UTs work like this.
> So here I suggest we switch back to ZKConnectionRegistry by default, and open 
> a new feature branch to finish the TODOs and the refactoring on UTs.
> As now it is already a big problem for me as I want to merge a feature branch 
> back to master but the state of UTs are a mess.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to