[
https://issues.apache.org/jira/browse/HBASE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255201#comment-13255201
]
stack commented on HBASE-5782:
------------------------------
Not sure I follow but I do know this patch more ambitious than what I was at....
+ You remove the 'other' sequence numbering system, unflushedEntries? That
looks good.
+ Are asserts on by default? We disabled them a while back I believe? You run
w/ asserts? (Yeah, thats a good thing to test -- should you use your guava test
instead?)
+ Its ugly we call it hlogFlush but internal we do appends (thats not your
change)
+ I agree that the reset of the the pending writes linked list needs to be done
under the synchronization held by hlogFlush
+ I like how you do pushback of edits if we fail....in hlogFlush.
+ On this thing:
{code}
+ // TODO: restore metric syncBatchSize.addAndGet(doneUpto -
this.syncedTillHere);
{code}
Its not used anywhere and it the math looked dodgy... then when you read it it
gets set to zero so I'm not so sure it is of any use.
> Edits can be appended out of seqid order since HBASE-4487
> ---------------------------------------------------------
>
> Key: HBASE-5782
> URL: https://issues.apache.org/jira/browse/HBASE-5782
> Project: HBase
> Issue Type: Bug
> Components: wal
> Affects Versions: 0.94.0
> Reporter: Gopinathan A
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.94.0
>
> Attachments: 5782-sketch.txt, 5782.txt, HBASE-5782.patch
>
>
> Create a table with 1000 splits, after the region assignemnt, kill the
> regionserver wich contains META table.
> Here few regions are missing after the log splitting and region assigment.
> HBCK report shows multiple region holes are got created.
> Same scenario was verified mulitple times in 0.92.1, no issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
