[ 
https://issues.apache.org/jira/browse/HBASE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255130#comment-13255130
 ] 

Jean-Daniel Cryans commented on HBASE-5782:
-------------------------------------------

bq. Don't hate me, just throwing this out there.

LOL

My current concerns:

 - Performance, and I'm not the only one concerned.
 - OOME, what happens if you enable deferred log flush and HDFS is slowing 
down? That's actually an issue with HBASE-4487 since the {{LinkedList}} of 
pending writes is unbounded whereas before simply appending to the file would 
slow you down.
 - This patch will make it that threads can sync data from threads that came in 
later. You need to check {{txid <= this.syncedTillHere}} again once you are 
past the {{synchronized(syncLock)}} and return if it was taken care of while 
you were blocking.
 - Deadlocks, you never know when adding new locks :)
                
> Not all the regions are getting assigned after the log splitting.
> -----------------------------------------------------------------
>
>                 Key: HBASE-5782
>                 URL: https://issues.apache.org/jira/browse/HBASE-5782
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.94.0
>            Reporter: Gopinathan A
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Blocker
>             Fix For: 0.94.0
>
>         Attachments: 5782.txt, HBASE-5782.patch
>
>
> Create a table with 1000 splits, after the region assignemnt, kill the 
> regionserver wich contains META table.
> Here few regions are missing after the log splitting and region assigment. 
> HBCK report shows multiple region holes are got created.
> Same scenario was verified mulitple times in 0.92.1, no issues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to