busbey commented on a change in pull request #1195: HBASE-23876 [WIP] Add JDK11
compilation and unit test support to nightly job
URL: https://github.com/apache/hbase/pull/1195#discussion_r385297704
##########
File path: dev-support/Jenkinsfile_GitHub
##########
@@ -144,8 +143,9 @@ pipeline {
YETUS_ARGS+=("--docker")
YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
YETUS_ARGS+=("--mvn-custom-repos")
-
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8-openjdk-amd64")
- YETUS_ARGS+=("--findbugs-home=/usr")
+ YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8")
+
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8,/usr/lib/jvm/java-11")
+ YETUS_ARGS+=("--multijdktests=compile,unit")
Review comment:
I personally prefer parallel. especially once we get the github integration
in place to list the tests and check them off as we go it'll be nice.
however, if we do serial I believe jenkins will optimize executor reuse. so
that might give a better experience (both us being nice to others and
minimizing total time to be "done") prior to that incremental progress
reporting.
do whichever you like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
