ndimiduk commented on a change in pull request #1195: HBASE-23876 [WIP] Add
JDK11 compilation and unit test support to nightly job
URL: https://github.com/apache/hbase/pull/1195#discussion_r385449600
##########
File path: dev-support/Jenkinsfile_GitHub
##########
@@ -144,8 +143,9 @@ pipeline {
YETUS_ARGS+=("--docker")
YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
YETUS_ARGS+=("--mvn-custom-repos")
-
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8-openjdk-amd64")
- YETUS_ARGS+=("--findbugs-home=/usr")
+ YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8")
+
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8,/usr/lib/jvm/java-11")
+ YETUS_ARGS+=("--multijdktests=compile,unit")
Review comment:
> Hurm. The test report still looks like a mixed bag. The test failures
table shows both jdks, but the test vote table only has jdk8. The footer entry
with the link to unit test console output also only has jdk8.
You're right. Have a look at the table printed over on
https://github.com/apache/hbase/pull/1214#issuecomment-591757259. This should
be filed as a bug/feature in Yetus?
> do whichever you like.
I've started plumbing in for parallel steps, since that's what nightly does
and I can follow along. This is more involved than I originally imagined. I'm
not sure how reporting of each check's success will work out -- right now we
have a single summary written by Yetus, after this I expect we'll have 3
summaries (general, jdk8, jdk11), each written back independently. I'm inclined
to not bother also collecting and writing a summary and the reports, given that
we want to invest in HBASE-23902.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
