[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255281#comment-13255281
]
Zhihong Yu commented on HBASE-5732:
-----------------------------------
I put the patch on review board, below are comments for the first page.
For disposeSasl():
{code}
+ } catch (IOException ioe) {
+ LOG.info("Error disposing of SASL client", ioe);
+ }
{code}
The above log should be at error level.
{code}
+ private synchronized boolean setupSaslConnection(final InputStream in2,
+ final OutputStream out2)
+ throws IOException {
{code}
The 'throws' should be on the same line as parameter 'out2'.
For handleSaslConnectionFailure():
{code}
+ if (ex instanceof RemoteException)
+ throw (RemoteException)ex;
+ throw new IOException(ex);
{code}
I think the if statement should check for IOException so that we don't create
IOException wrapping ex, another IOException.
{code}
+ private void writeHeader() throws IOException {
+ // Write out the ConnectionHeader
+ out.writeInt(header.getSerializedSize());
+ header.writeTo(out);
+ }
{code}
Do we need to call out.flush() at the end of the above method ?
{code}
+ if (closeException == null) {
+ if (!calls.isEmpty()) {
+ LOG.warn(
+ "A connection is closed for no cause and calls are not empty");
+
+ // clean up calls anyway
+ closeException = new IOException("Unexpected closed connection");
{code}
Should we record the size of calls in the above warning and IOE ?
> Remove the SecureRPCEngine and merge the security-related logic in the core
> engine
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5732
> URL: https://issues.apache.org/jira/browse/HBASE-5732
> Project: HBase
> Issue Type: Improvement
> Reporter: Devaraj Das
> Attachments: rpcengine-merge.patch
>
>
> Remove the SecureRPCEngine and merge the security-related logic in the core
> engine. Follow up to HBASE-5727.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
