[
https://issues.apache.org/jira/browse/HBASE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255285#comment-13255285
]
Zhihong Yu commented on HBASE-5732:
-----------------------------------
Thanks for the hint about compilation, Devaraj.
Would it make sense to change security profile to the default profile (insecure
build doesn't compile) ?
For HBaseServer.setResponse():
{code}
+ long hint = ohint.getWritableSize() + Bytes.SIZEOF_INT +
Bytes.SIZEOF_INT;
{code}
The two Bytes.SIZEOF_INT can be written as Bytes.SIZEOF_INT*2.
{code}
- builder.setError(error != null);
+ //builder.setStatus(
{code}
The above comment can be removed.
{code}
- ByteBuffer bb = buf.getByteBuffer();
- bb.position(0);
- this.response = bb;
+ this.response = buf.getByteBuffer();
{code}
Why was the position(0) call removed ?
> Remove the SecureRPCEngine and merge the security-related logic in the core
> engine
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5732
> URL: https://issues.apache.org/jira/browse/HBASE-5732
> Project: HBase
> Issue Type: Improvement
> Reporter: Devaraj Das
> Attachments: rpcengine-merge.patch
>
>
> Remove the SecureRPCEngine and merge the security-related logic in the core
> engine. Follow up to HBASE-5727.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
