[
https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255323#comment-13255323
]
stack commented on HBASE-5788:
------------------------------
Is MetricsStorage for Region metrics only? If so, call it RegionMetrics? Or
maybe its generic metrics storage for this package? If so, the name is right.
Should it be down in the metrics package? Regardless, new class needs class
comment explaining class scope. Does it have to public? Can it be private to
the package at least? Lines < 100 chars. Why are data members in this new
class public rather than private? Even if they are static. And static data
members probably ain't a good idea because then there is one only per JVM and
there can be many regionservers in the one JVM; e.g. in testing. Yeah, do its
method names need to be public? Can these be package private? Hmm... maybe
they need to be public because called from the metrics subpackage? I like all
the code that comes out of HRegion. Thats good. And no harm in a basic unit
test that your new class is basically working. Any worries w/ concurrent
access? Good stuff Elliott.
> Move Dynamic Metrics storage off of HRegion.
> --------------------------------------------
>
> Key: HBASE-5788
> URL: https://issues.apache.org/jira/browse/HBASE-5788
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Minor
> Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch,
> HBASE-5788-2.patch
>
>
> HRegion right now has the responsibility of storing static counts and latency
> numbers for use by the metrics package. Since these maps are incremented and
> set from lots of places it makes adding functionality hard.
>
> So move the metrics functionality into SchemaMetrics making it more than just
> a class for naming. The next step will be to simplify the api exposed so
> that using it will be easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
