HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace
usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281415
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
##########
@@ -6056,17 +6078,20 @@ public void testCellTTLs() throws IOException {
final byte[] q3 = Bytes.toBytes("q3");
final byte[] q4 = Bytes.toBytes("q4");
- HTableDescriptor htd = new
HTableDescriptor(TableName.valueOf(name.getMethodName()));
- HColumnDescriptor hcd = new HColumnDescriptor(fam1);
- hcd.setTimeToLive(10); // 10 seconds
- htd.addFamily(hcd);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(
+ TableName.valueOf(name.getMethodName()));
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor
familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam1);
+ familyDescriptor.setTimeToLive(10); // 10 seconds
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
