HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace
usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281197
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
##########
@@ -2806,15 +2804,18 @@ public void testGetWithFilter() throws IOException,
InterruptedException {
byte[] value2 = Bytes.toBytes("value2");
final int maxVersions = 3;
- HColumnDescriptor hcd = new HColumnDescriptor(fam1);
- hcd.setMaxVersions(maxVersions);
- HTableDescriptor htd = new
HTableDescriptor(TableName.valueOf("testFilterAndColumnTracker"));
- htd.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor
familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam1);
+ familyDescriptor.setMaxVersions(maxVersions);
Review comment:
Use the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
