[
https://issues.apache.org/jira/browse/HBASE-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255331#comment-13255331
]
[email protected] commented on HBASE-2214:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4726/#review6968
-----------------------------------------------------------
I think this an important addition. Any chance of a test Ferdy to demonstrate
it works. Its kinda crazy you only have to do this much to make it work.
/src/main/java/org/apache/hadoop/hbase/client/Scan.java
<https://reviews.apache.org/r/4726/#comment15518>
Good
/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/4726/#comment15519>
Needs to be public?
/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java
<https://reviews.apache.org/r/4726/#comment15520>
This is not used?
/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java
<https://reviews.apache.org/r/4726/#comment15521>
Is this a good name for this attribute? Its the result size per next?
getMaxResultSize? Or something like that?
- Michael
On 2012-04-15 13:38:31, ferdy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4726/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-15 13:38:31)
bq.
bq.
bq. Review request for hbase and Ted Yu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HBASE-2214 per scan max buffersize.
bq.
bq.
bq. This addresses bug HBASE-2214.
bq. https://issues.apache.org/jira/browse/HBASE-2214
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/Scan.java 1326084
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1326084
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1326084
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java
1326084
bq.
/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
1326084
bq.
bq. Diff: https://reviews.apache.org/r/4726/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. ferdy
bq.
bq.
> Do HBASE-1996 -- setting size to return in scan rather than count of rows --
> properly
> -------------------------------------------------------------------------------------
>
> Key: HBASE-2214
> URL: https://issues.apache.org/jira/browse/HBASE-2214
> Project: HBase
> Issue Type: New Feature
> Reporter: stack
> Assignee: Ferdy Galema
> Fix For: 0.94.1
>
> Attachments: HBASE-2214-0.94.txt, HBASE-2214_with_broken_TestShell.txt
>
>
> The notion that you set size rather than row count specifying how many rows a
> scanner should return in each cycle was raised over in hbase-1966. Its a
> good one making hbase "regular" though the data under it may vary.
> HBase-1966 was committed but the patch was constrained by the fact that it
> needed to not change RPC interface. This issue is about doing hbase-1966 for
> 0.21 in a clean, unconstrained way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
