[
https://issues.apache.org/jira/browse/HBASE-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255866#comment-13255866
]
[email protected] commented on HBASE-2214:
------------------------------------------------------
bq. On 2012-04-17 05:46:43, Michael Stack wrote:
bq. > I think this an important addition. Any chance of a test Ferdy to
demonstrate it works. Its kinda crazy you only have to do this much to make it
work.
It was indeed to good to be true. It does not yet work. There are still some
other classes that need modification. (In order to make it work by piggybacking
on the existing maxScannerResultSize mechanism).
Will get back at this with new version of patch.
Thanks.
bq. On 2012-04-17 05:46:43, Michael Stack wrote:
bq. > /src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java,
line 26
bq. > <https://reviews.apache.org/r/4726/diff/2/?file=101902#file101902line26>
bq. >
bq. > This is not used?
It is, namely in the javadoc comment. Removing it makes the link unclickable.
bq. On 2012-04-17 05:46:43, Michael Stack wrote:
bq. > /src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java, line
3376
bq. >
<https://reviews.apache.org/r/4726/diff/2/?file=101900#file101900line3376>
bq. >
bq. > Needs to be public?
I cannot reduce the visibilty because it needs to in the interface. (Yeah it's
a bit of a hack I guess)
bq. On 2012-04-17 05:46:43, Michael Stack wrote:
bq. > /src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java,
line 59
bq. > <https://reviews.apache.org/r/4726/diff/2/?file=101902#file101902line59>
bq. >
bq. > Is this a good name for this attribute? Its the result size per
next? getMaxResultSize? Or something like that?
maxResultSize seems better indeed. I will rename this next patch.
- ferdy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4726/#review6968
-----------------------------------------------------------
On 2012-04-15 13:38:31, ferdy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4726/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-15 13:38:31)
bq.
bq.
bq. Review request for hbase and Ted Yu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HBASE-2214 per scan max buffersize.
bq.
bq.
bq. This addresses bug HBASE-2214.
bq. https://issues.apache.org/jira/browse/HBASE-2214
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/Scan.java 1326084
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1326084
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1326084
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java
1326084
bq.
/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
1326084
bq.
bq. Diff: https://reviews.apache.org/r/4726/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. ferdy
bq.
bq.
> Do HBASE-1996 -- setting size to return in scan rather than count of rows --
> properly
> -------------------------------------------------------------------------------------
>
> Key: HBASE-2214
> URL: https://issues.apache.org/jira/browse/HBASE-2214
> Project: HBase
> Issue Type: New Feature
> Reporter: stack
> Assignee: Ferdy Galema
> Fix For: 0.94.1
>
> Attachments: HBASE-2214-0.94.txt, HBASE-2214_with_broken_TestShell.txt
>
>
> The notion that you set size rather than row count specifying how many rows a
> scanner should return in each cycle was raised over in hbase-1966. Its a
> good one making hbase "regular" though the data under it may vary.
> HBase-1966 was committed but the patch was constrained by the fact that it
> needed to not change RPC interface. This issue is about doing hbase-1966 for
> 0.21 in a clean, unconstrained way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
