[ https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256121#comment-13256121 ]
Enis Soztutar commented on HBASE-5788: -------------------------------------- bq. I moved metrics about get/put/delete/icv into a helper class that mutates data in RegionMetricsStorage. I was hoping to go that way with pretty simple helper classes that expose update methods. Then SchemaMetrics can be mutated in the same way and metric naming can be handled by static helpers only. Ok, i see. Helper methods should help. But I think we should get rid of the static state there. I also left a comment on HBASE-3614. > Move Dynamic Metrics storage off of HRegion. > -------------------------------------------- > > Key: HBASE-5788 > URL: https://issues.apache.org/jira/browse/HBASE-5788 > Project: HBase > Issue Type: Improvement > Components: regionserver > Reporter: Elliott Clark > Assignee: Elliott Clark > Priority: Minor > Fix For: 0.96.0 > > Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, > HBASE-5788-2.patch, HBASE-5788-3.patch, HBASE-5788-4.patch > > > HRegion right now has the responsibility of storing static counts and latency > numbers for use by the metrics package. Since these maps are incremented and > set from lots of places it makes adding functionality hard. > > So move the metrics functionality into SchemaMetrics making it more than just > a class for naming. The next step will be to simplify the api exposed so > that using it will be easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira