nyl3532016 commented on a change in pull request #1279: HBASE-23949 refactor
loadBalancer implements for rsgroup balance by t…
URL: https://github.com/apache/hbase/pull/1279#discussion_r392779758
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/SimpleLoadBalancer.java
##########
@@ -594,10 +597,13 @@ private void addRegionPlan(final
MinMaxPriorityQueue<RegionPlan> regionsToMove,
regionsToReturn.add(rp);
}
+ /**
+ * Override to invoke {@link #setClusterLoad} before balance
+ */
@Override
- public List<RegionPlan> balanceCluster(TableName tableName,
- Map<ServerName, List<RegionInfo>> clusterState) throws HBaseIOException {
- LOG.debug("Start Generate Balance plan for table: " + tableName);
- return balanceCluster(clusterState);
+ public synchronized List<RegionPlan>
+ balanceCluster(Map<TableName, Map<ServerName, List<RegionInfo>>>
clusterLoadPerTable) {
+ setClusterLoad(clusterLoadPerTable);
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services