Apache-HBase commented on issue #1279: HBASE-23949 refactor loadBalancer implements for rsgroup balance by t… URL: https://github.com/apache/hbase/pull/1279#issuecomment-599407618 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 6s | master passed | | +1 :green_heart: | checkstyle | 1m 13s | master passed | | -1 :x: | spotbugs | 2m 12s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 17s | the patch passed | | -0 :warning: | checkstyle | 1m 18s | hbase-server: The patch generated 36 new + 408 unchanged - 9 fixed = 444 total (was 417) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 16m 44s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | spotbugs | 2m 32s | hbase-server generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 41m 49s | | | Reason | Tests | |-------:|:------| | FindBugs | module:hbase-server | | | Inconsistent synchronization of org.apache.hadoop.hbase.master.balancer.BaseLoadBalancer.isByTable; locked 66% of time Unsynchronized access at BaseLoadBalancer.java:66% of time Unsynchronized access at BaseLoadBalancer.java:[line 1051] | | | org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.balanceCluster(Map) makes inefficient use of keySet iterator instead of entrySet iterator At RSGroupBasedLoadBalancer.java:keySet iterator instead of entrySet iterator At RSGroupBasedLoadBalancer.java:[line 143] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1279 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux add793689b4a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f66cbe1a40 | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/7/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/7/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | Max. process+thread count | 93 (vs. ulimit of 10000) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1279/7/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
