saintstack commented on a change in pull request #1280: HBASE-23799 Make our
core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r394100184
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -1985,21 +1985,20 @@ public SecurityCapabilitiesResponse
getSecurityCapabilities(RpcController contro
/**
* Determines if there is a MasterCoprocessor deployed which implements
- * {@link
org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.AccessControlService.Interface}.
+ * {@link AccessControlService.Interface}.
*/
boolean hasAccessControlServiceCoprocessor(MasterCoprocessorHost cpHost) {
- return checkCoprocessorWithService(
- cpHost.findCoprocessors(MasterCoprocessor.class),
AccessControlService.Interface.class);
+ return
checkCoprocessorWithService(cpHost.findCoprocessors(MasterCoprocessor.class),
+ AccessControlService.Interface.class);
}
/**
* Determines if there is a MasterCoprocessor deployed which implements
- * {@link
org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos.VisibilityLabelsService.Interface}.
+ * {@link VisibilityLabelsService.Interface}.
*/
boolean hasVisibilityLabelsServiceCoprocessor(MasterCoprocessorHost cpHost) {
- return checkCoprocessorWithService(
- cpHost.findCoprocessors(MasterCoprocessor.class),
- VisibilityLabelsService.Interface.class);
+ return
checkCoprocessorWithService(cpHost.findCoprocessors(MasterCoprocessor.class),
+ VisibilityLabelsService.Interface.class);
}
/**
Review comment:
What happens when an old CP impl tries to go against hbase3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
