saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#discussion_r393908442
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java ########## @@ -35,6 +34,7 @@ import org.apache.yetus.audience.InterfaceAudience; import org.apache.hbase.thirdparty.com.google.common.base.Preconditions; +import org.apache.hbase.thirdparty.com.google.protobuf.RpcChannel; Review comment: Yeah, ditto. These are public classes. This stuff is used internally so should be fine just changing it... its just that hbase-shaded-protobuf needs to be on the CLASSPATH? I suppose it was anyways? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
