ndimiduk commented on a change in pull request #1305: HBASE-23984 [Flakey
Tests] TestMasterAbortAndRSGotKilled fails in tea…
URL: https://github.com/apache/hbase/pull/1305#discussion_r394692563
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/AssignRegionHandler.java
##########
@@ -105,50 +102,54 @@ public void process() throws IOException {
if (previous != null) {
Review comment:
nit: not your code, but i liked better the three-way if-elseif-else
structure from `HRegionServer#closeRegion`. Makes it nice and obvious that
there are three states possible from the return value. It would also be nice to
have a log message in all three cases, rather than silently doing nothing for
the `previous == null` case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
