ndimiduk commented on a change in pull request #1305: HBASE-23984 [Flakey
Tests] TestMasterAbortAndRSGotKilled fails in tea…
URL: https://github.com/apache/hbase/pull/1305#discussion_r394657691
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -2446,6 +2450,12 @@ public RSRpcServices getRSRpcServices() {
*/
@Override
public void abort(String reason, Throwable cause) {
+ if (isAborted()) {
+ // Don't run multiple aborts; fills logs w/ spew.
+ LOG.info("Abort called but server already aborted; by-passing; abort
invoked because {}",
Review comment:
I'm not a fan of logging exceptions except for `ERROR` or `FATAL`. Sometimes
`DEBUG` is okay, but it's rarely helpful to an operator, and here I would
consider it as "log spew" as well :) I should hope that the custom tailored
`reason` message is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
