saintstack commented on a change in pull request #1301: HBASE-23833. The
relocated hadoop-thirdparty protobuf breaks HBase asyncwal
URL: https://github.com/apache/hbase/pull/1301#discussion_r394797233
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java
##########
@@ -363,7 +410,7 @@ private void sendSaslMessage(ChannelHandlerContext ctx,
byte[] payload,
if (payload != null) {
// Was ByteStringer; fix w/o using ByteStringer. Its in hbase-protocol
// and we want to keep that out of hbase-server.
- builder.setPayload(ByteString.copyFrom(payload));
+ BuilderPayloadSetter.setter(builder, payload);
Review comment:
The builder is from HDFS. It is NOT a pb. It has pbs in it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
