saintstack commented on a change in pull request #1301: HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal URL: https://github.com/apache/hbase/pull/1301#discussion_r394798728
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/ProtobufDecoder.java ########## @@ -0,0 +1,116 @@ +package org.apache.hadoop.hbase.io.asyncfs; + +import org.apache.hbase.thirdparty.io.netty.buffer.ByteBuf; +import org.apache.hbase.thirdparty.io.netty.buffer.ByteBufUtil; +import org.apache.hbase.thirdparty.io.netty.channel.ChannelHandlerContext; +import org.apache.hbase.thirdparty.io.netty.handler.codec.MessageToMessageDecoder; +import org.apache.hbase.thirdparty.io.netty.util.internal.ObjectUtil; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.util.List; + +/** Modified based on io.netty.handler.codec.protobuf.ProtobufDecoder */ Review comment: Needs comment on what this is doing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
