Apache9 commented on a change in pull request #1280: HBASE-23799 Make our core
coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r395123809
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -1985,21 +1985,20 @@ public SecurityCapabilitiesResponse
getSecurityCapabilities(RpcController contro
/**
* Determines if there is a MasterCoprocessor deployed which implements
- * {@link
org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.AccessControlService.Interface}.
+ * {@link AccessControlService.Interface}.
*/
boolean hasAccessControlServiceCoprocessor(MasterCoprocessorHost cpHost) {
- return checkCoprocessorWithService(
- cpHost.findCoprocessors(MasterCoprocessor.class),
AccessControlService.Interface.class);
+ return
checkCoprocessorWithService(cpHost.findCoprocessors(MasterCoprocessor.class),
+ AccessControlService.Interface.class);
}
/**
* Determines if there is a MasterCoprocessor deployed which implements
- * {@link
org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos.VisibilityLabelsService.Interface}.
+ * {@link VisibilityLabelsService.Interface}.
*/
boolean hasVisibilityLabelsServiceCoprocessor(MasterCoprocessorHost cpHost) {
- return checkCoprocessorWithService(
- cpHost.findCoprocessors(MasterCoprocessor.class),
- VisibilityLabelsService.Interface.class);
+ return
checkCoprocessorWithService(cpHost.findCoprocessors(MasterCoprocessor.class),
+ VisibilityLabelsService.Interface.class);
}
/**
Review comment:
if you use the CP client to talk to hbase3 then it should be fire, the
shaded and non-shaded version are wire compatible, but the CPs at server side
should be recompiled to make use of the shaded protobuf version. This maybe a
bit difficult for users, we should tell user how to do the replacement on the
generated protobuf classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
