ndimiduk commented on a change in pull request #1310: HBASE-23957 [flakey test]
client.TestMultiParallel fails to read hbas…
URL: https://github.com/apache/hbase/pull/1310#discussion_r395213371
##########
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
##########
@@ -207,7 +207,7 @@ boolean cleanupTestDir(final String subdir) {
* Unit test will use a subdirectory of this directory.
* @see #setupDataTestDir()
*/
- private Path getBaseTestDir() {
+ public Path getBaseTestDir() {
Review comment:
You sure you should change the privacy here? The javadoc comment here
literally says "Should not be used by the unit tests, hence its's private."
Seems like callers are supposed to use `getDataTestDir`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
