ndimiduk commented on a change in pull request #1310: HBASE-23957 [flakey test]
client.TestMultiParallel fails to read hbas…
URL: https://github.com/apache/hbase/pull/1310#discussion_r395223011
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncClusterAdminApi.java
##########
@@ -139,14 +173,14 @@ public void testAllClusterOnlineConfigChange() throws
IOException {
private void replaceHBaseSiteXML() throws IOException {
// make a backup of hbase-site.xml
- Files.copy(cnfPath, cnf3Path, StandardCopyOption.REPLACE_EXISTING);
+ Files.copy(newCnfPathes.get(0), newCnfPathes.get(2),
StandardCopyOption.REPLACE_EXISTING);
Review comment:
nit for other readers: since you're here cleaning up, can you use
descriptive names for these variables? Instead of `cnfPath{1,2,3}` or this
array of paths, how about
* `rsConfigFilePath` instead of `cnfPath`
* `overwriteFilePath` instead of `cnf1Path`
* `rsConfigFileBackup` instead of `cnf3Path`
IMHO, descriptive variable names are better than comments. Just a suggestion
:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
