saintstack commented on issue #1311: HBASE-23984 [Flakey Tests] 
TestMasterAbortAndRSGotKilled fails in tea…
URL: https://github.com/apache/hbase/pull/1311#issuecomment-601535096
 
 
   bq. If you really want to do this to let the test pass, I suggest you add 
the removal in the handleException method, and add a FIXME or TODO comment to 
say that this is just for making test pass, should be addressed later.
   
   I can move it to handleException, np. I will NOT note that it a UT fix only. 
There is an obvious hole here holds up shutdowns and shutdowns are not UT only.
   
   These Handlers strike me as arbitrary regards where stuff goes; no wonder 
there are holes.
   
   Let me put up another patch w/ your suggestions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to