saintstack commented on a change in pull request #1311: HBASE-23984 [Flakey
Tests] TestMasterAbortAndRSGotKilled fails in tea…
URL: https://github.com/apache/hbase/pull/1311#discussion_r395434478
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/AssignRegionHandler.java
##########
@@ -132,11 +131,11 @@ public void process() throws IOException {
// opening can not be interrupted by a close request any more.
region = HRegion.openHRegion(regionInfo, htd, rs.getWAL(regionInfo),
rs.getConfiguration(),
rs, null);
+ rs.postOpenDeployTasks(new PostOpenDeployContext(region, openProcId,
masterSystemTime));
Review comment:
bq. IIRC, the design here is that, postOpenDeployTasks is the PONR, if we
arrive here, then we can not revert back, the only way to address the exception
is to abort the region server.
Ok. That helps. Let me add above as comment and ensure the above happens and
that I get my fix in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
