bharathv commented on a change in pull request #1260: HBASE-23881 Ensure Netty
client receives at least one response before…
URL: https://github.com/apache/hbase/pull/1260#discussion_r397624729
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java
##########
@@ -114,7 +122,10 @@ public void handlerAdded(ChannelHandlerContext ctx) {
if (initialResponse != null) {
writeResponse(ctx, initialResponse);
}
- tryComplete(ctx);
+ // HBASE-23881 We do not want to check if the SaslClient thinks the
handshake is
Review comment:
Any chance the second part of your comment be added as a code comment? I was
digging into the patch and this comment made it much clear for me. That also
explains why we don't see this issue in the GSS/Kerberos implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
