Apache9 commented on a change in pull request #1260: HBASE-23881 Ensure Netty
client receives at least one response before…
URL: https://github.com/apache/hbase/pull/1260#discussion_r391972390
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/security/AbstractHBaseSaslRpcClient.java
##########
@@ -88,6 +88,14 @@ protected AbstractHBaseSaslRpcClient(Configuration conf,
}
}
+ /**
+ * Computes the initial response a client sends to a server to begin the SASL
+ * challenge/response handshake. If the client's SASL mechanism does not
require
+ * that an initial response is sent to begin the handshake, this method will
return
+ * an empty byte array, indicating no initial response needs to be sent by
this client.
+ *
+ * @return The client's initial response to send the server, or an empty
byte array
+ */
public byte[] getInitialResponse() throws SaslException {
Review comment:
I think we better returns null for no initial response here? Maybe some sasl
implementation just use an empty token...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
