GeorryHuang commented on a change in pull request #1292: HBASE-23994:Add WebUI to Canary URL: https://github.com/apache/hbase/pull/1292#discussion_r399784555
########## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ########## @@ -1464,6 +1464,12 @@ public static final String HBASE_CANARY_READ_RAW_SCAN_KEY = "hbase.canary.read.raw.enabled"; + public static final String HBASE_CANARY_INFO_PORT = "hbase.canary.info.port"; Review comment: > Is it possible to not add these configurations in HConstants? Just put them in the CanaryTool class? ok, I will modify the code here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
