GeorryHuang commented on a change in pull request #1292: HBASE-23994:Add WebUI
to Canary
URL: https://github.com/apache/hbase/pull/1292#discussion_r406635338
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java
##########
@@ -122,6 +125,35 @@
*/
@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.TOOLS)
public class CanaryTool implements Tool, Canary {
+ public static final String HBASE_CANARY_INFO_PORT = "hbase.canary.info.port";
+
+ public static final int DEFAULT_CANARY_INFOPORT = 16050;
+
+ public static final String HBASE_CANARY_INFO_BINDADDRESS =
"hbase.canary.info.bindAddress";
+
+
+ private void putUpWebUI() throws IOException {
+ if (zookeeperMode) {
+ LOG.info("WebUI is not supported in Zookeeper mode");
Review comment:
> nit: could skip these warnings (and the whole function body) when
`HBASE_CANARY_INFO_PORT == -1`
will deal with it later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
