saintstack commented on a change in pull request #1388: HBASE-24079 [Flakey
Tests] Misc fixes and debug; fix BindException in…
URL: https://github.com/apache/hbase/pull/1388#discussion_r400511724
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java
##########
@@ -178,22 +181,27 @@ private void testRowsSeenMetric(boolean async) throws
Exception {
baseScan = new Scan();
baseScan.setScanMetricsEnabled(true);
baseScan.setAsyncPrefetch(async);
- testRowsSeenMetric(baseScan);
-
- // Test case that only a single result will be returned per RPC to the
serer
- baseScan.setCaching(1);
- testRowsSeenMetric(baseScan);
-
- // Test case that partial results are returned from the server. At most
one cell will be
- // contained in each response
- baseScan.setMaxResultSize(1);
- testRowsSeenMetric(baseScan);
-
- // Test case that size limit is set such that a few cells are returned per
partial result from
- // the server
- baseScan.setCaching(NUM_ROWS);
- baseScan.setMaxResultSize(getCellHeapSize() * (NUM_COLS - 1));
- testRowsSeenMetric(baseScan);
+ try {
+ testRowsSeenMetric(baseScan);
+
+ // Test case that only a single result will be returned per RPC to the
serer
+ baseScan.setCaching(1);
+ testRowsSeenMetric(baseScan);
+
+ // Test case that partial results are returned from the server. At most
one cell will be
+ // contained in each response
+ baseScan.setMaxResultSize(1);
+ testRowsSeenMetric(baseScan);
+
+ // Test case that size limit is set such that a few cells are returned
per partial result from
+ // the server
+ baseScan.setCaching(NUM_ROWS);
+ baseScan.setMaxResultSize(getCellHeapSize() * (NUM_COLS - 1));
+ testRowsSeenMetric(baseScan);
+ } catch (Throwable t) {
+ LOG.error("FAIL", t);
Review comment:
Debug. Narrowing in on where exception comes up out of. Probably useless.
Fell gets desperate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
