saintstack commented on a change in pull request #1388: HBASE-24079 [Flakey
Tests] Misc fixes and debug; fix BindException in…
URL: https://github.com/apache/hbase/pull/1388#discussion_r400512845
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
##########
@@ -192,12 +188,19 @@ public String dumpQueue() {
public synchronized boolean requestSplit(final Region r) {
// don't split regions that are blocking
- if (shouldSplitRegion() && ((HRegion)r).getCompactPriority() >=
PRIORITY_USER) {
- byte[] midKey = ((HRegion)r).checkSplit();
- if (midKey != null) {
- requestSplit(r, midKey);
- return true;
+ HRegion hr = (HRegion)r;
+ try {
+ if (shouldSplitRegion() && hr.getCompactPriority() >= PRIORITY_USER) {
+ byte[] midKey = hr.checkSplit();
+ if (midKey != null) {
+ requestSplit(r, midKey);
+ return true;
+ }
}
+ } catch (IndexOutOfBoundsException e) {
+ // We get this sometimes. Not sure why. Catch and return false; no split
request.
Review comment:
Well, turns out the IndexOutOfBoundsException is thrown by a TestCompaction
fail-checking test (?). Subsequent patch changes the test to make it plain
when test throwing one of these. I think I've seen this in production too. When
get more detail, will file JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
