lokiore commented on a change in pull request #1201: HBASE-23639 : Moving 
classes out of hbase-it /test for direct API use of chaos.
URL: https://github.com/apache/hbase/pull/1201#discussion_r402489924
 
 

 ##########
 File path: hbase-it/pom.xml
 ##########
 @@ -154,10 +154,29 @@
       <type>test-jar</type>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.apache.hbase</groupId>
+      <artifactId>hbase-server</artifactId>
+      <type>test-jar</type>
 
 Review comment:
   yes I am moving these classes from src/test/java -> src/main/java as 
discussed with Sean and Andrew that any code under test with an audience and 
stability annotation is not meaningful and anti-pattern.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to