lokiore commented on a change in pull request #1201: HBASE-23639 : Moving classes out of hbase-it /test for direct API use of chaos. URL: https://github.com/apache/hbase/pull/1201#discussion_r403510589
########## File path: hbase-it/src/main/java/org/apache/hadoop/hbase/chaos/factories/NoKillMonkeyFactory.java ########## @@ -39,11 +39,13 @@ import org.apache.hadoop.hbase.chaos.monkies.PolicyBasedChaosMonkey; import org.apache.hadoop.hbase.chaos.policies.PeriodicRandomActionPolicy; import org.apache.hadoop.hbase.chaos.policies.TwoConcurrentActionPolicy; +import org.apache.yetus.audience.InterfaceAudience; /** * Monkey factory to create a ChaosMonkey that will not need access to ssh. It will not * kill any services and it will not perform any restarts. */ [email protected] Review comment: I think MonkeyFactories are mostly expected as a param to ChaosMonkeyRunner and are not used directly, but if you think to make them LimitedPrivate is more helpful, then I'll change this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
