huaxiangsun commented on issue #1425: HBASE-24105 [Flakey Test] regionserver.TestRegionReplicas URL: https://github.com/apache/hbase/pull/1425#issuecomment-608214811 Thanks Stack. Good question, worth more time to figure it out, will check the test failures to see if it is related. On Thu, Apr 2, 2020, 6:55 PM Michael Stack <[email protected]> wrote: > *@saintstack* commented on this pull request. > ------------------------------ > > In > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java > <https://github.com/apache/hbase/pull/1425#discussion_r402689774>: > > > @@ -117,9 +117,7 @@ public void process() throws IOException { > HConstants.NO_SEQNUM, Procedure.NO_PROC_ID, -1, regionInfo)); > > // Done! Region is closed on this RS > - this.rsServices.getRegionsInTransitionInRS(). > - remove(this.regionInfo.getEncodedNameAsBytes(), Boolean.FALSE); > - LOG.debug("Closed {}" + region.getRegionInfo().getRegionNameAsString()); > > Hmm.. Is it the finally that is wrong? > > Here we remove only if value matches FALSE. The finally removes whatever > the value. > > But I suppose no one else can add an entry while there is one in the map > so the finally remove should be fine? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/hbase/pull/1425#pullrequestreview-386885709>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AO46O2XNH3ZLCP3XCWFEW23RKU6Z7ANCNFSM4L3FIZJA> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
