huaxiangsun commented on a change in pull request #1425: HBASE-24105 [Flakey
Test] regionserver.TestRegionReplicas
URL: https://github.com/apache/hbase/pull/1425#discussion_r403387259
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java
##########
@@ -117,9 +117,7 @@ public void process() throws IOException {
HConstants.NO_SEQNUM, Procedure.NO_PROC_ID, -1, regionInfo));
// Done! Region is closed on this RS
- this.rsServices.getRegionsInTransitionInRS().
- remove(this.regionInfo.getEncodedNameAsBytes(), Boolean.FALSE);
- LOG.debug("Closed {}" + region.getRegionInfo().getRegionNameAsString());
Review comment:
@saintstack In this specific context, remove only if value matches FALSE or
remove anyway is same. It enters in the loop with value FALSE and it wont be
changed to TRUE(going through the code).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
