busbey commented on a change in pull request #12: HBASE-24124 hbase-filesystem to use guava from hbase-thirdparty URL: https://github.com/apache/hbase-filesystem/pull/12#discussion_r404348978
########## File path: hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/HBaseObjectStoreSemantics.java ########## @@ -58,6 +57,7 @@ import org.apache.hadoop.hbase.oss.sync.TreeLockManager.Depth; import org.apache.hadoop.security.AccessControlException; import org.apache.hadoop.util.Progressable; +import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting; Review comment: I like using hbase-thirdparty, but this means we need to have a declared dependency on it in the hbase-oss pom instead of relying on implicit inclusion via a transitive dependency. If we're only using it for `VisibleForTesting` I'd also be cool with just removing that annotation and including a note in the javadoc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
