jojochuang commented on issue #12: HBASE-24124 hbase-filesystem to use guava from hbase-thirdparty URL: https://github.com/apache/hbase-filesystem/pull/12#issuecomment-610128810 So... turns out the hbase1 profile declares direct dependency on hbase-thirdparty. In fact, the code wouldn't compile without it with hbase1 profile because HBASE-22386 added an import of the shaded guava class. > Also note that we expressly moved away from hbase-thirdparty as a part of HBASE-22393 (#2 ) so please make sure the resultant jar properly lists hbase-thirdparty as a transitive dependency. > > AFAIK nothing was added to our LICENSE/NOTICE for guava, so those should already be fine. My understanding is because https://issues.apache.org/jira/browse/HBASE-22393?focusedCommentId=16837556&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16837556 > Instead of re-shading all of hbase-thirdparty, the only thing I'm using is Guava's VisibleForTesting so I just shade that directly and dropped the old dependency. Also note that curator 4.2.0 declare dependency on guava 27.0. So if I want to remove guava I will also need to exclude guava from curator (curator shades guava so the guava dependency is redundant)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
