huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey
Test: TestReplicationAdminWithClusters timeout
URL: https://github.com/apache/hbase/pull/1441#discussion_r404449097
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##########
@@ -579,8 +579,8 @@ private void
interruptOrAbortWhenFail(ReplicationQueueOperation op) {
if (e.getCause() != null && e.getCause() instanceof
KeeperException.SystemErrorException
&& e.getCause().getCause() != null && e.getCause()
.getCause() instanceof InterruptedException) {
- throw new RuntimeException(
- "Thread is interrupted, the replication source may be terminated");
+ LOG.info("Thread is interrupted, the replication source may be
terminated");
+ return;
Review comment:
the interrupt flap has been set up in the zkwatcher layer and upper layer
handles this flag nicely.
zkw.interruptedException(ie);
https://github.com/apache/hbase/blob/master/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java#L637,
in the outside loop, it will handle this interrupt flag and terminate the
thread.
Inside isActive() of the following loop, it will return false if
isInterrupted flag is true.
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java#L101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
