huaxiangsun commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout URL: https://github.com/apache/hbase/pull/1441#issuecomment-610186156 > > If RuntimeException is too general, maybe we could introduce a special exception and throw it, and at some places we catch it and just ignore it and quit. > > From my read, it seems like propagating the `InterruptException` is a reasonable course of action. The `run` loop appears to handle it properly. Indeed, that is my first approach. I tried to rethrow the InterruptedException from communication layer, the nit is that there will be lots of methods which needs to throw InterruptedException in their signature. Especially in shipEdits(), it catches all exceptions and it needs to rethrow InterruptedException as a special case. @ndimiduk , what do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
