ndimiduk commented on a change in pull request #1437: HBASE-24055 Make
AsyncFSWAL can run on EC cluster
URL: https://github.com/apache/hbase/pull/1437#discussion_r404454822
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java
##########
@@ -502,8 +524,8 @@ private static FanOutOneBlockAsyncDFSOutput
createOutput(DistributedFileSystem d
try {
stat = FILE_CREATOR.create(namenode, src,
FsPermission.getFileDefault().applyUMask(FsPermission.getUMask(conf)),
clientName,
- new EnumSetWritable<>(overwrite ? EnumSet.of(CREATE, OVERWRITE) :
EnumSet.of(CREATE)),
- createParent, replication, blockSize,
CryptoProtocolVersion.supported());
+ getCreateFlags(overwrite), createParent, replication, blockSize,
Review comment:
nice cleanup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services