saintstack commented on a change in pull request #1437: HBASE-24055 Make
AsyncFSWAL can run on EC cluster
URL: https://github.com/apache/hbase/pull/1437#discussion_r404484534
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java
##########
@@ -272,6 +272,15 @@ private static FileCreator createFileCreator() throws
NoSuchMethodException {
return createFileCreator2();
}
+ private static CreateFlag loadShouldReplicateFlag() {
+ try {
+ return CreateFlag.valueOf("SHOULD_REPLICATE");
+ } catch (IllegalArgumentException e) {
+ LOG.debug("can not find SHOULD_REPLICATE flag, should be hadoop 2.x", e);
Review comment:
This is how we test if the the SHOULD_REPLICATE flag is available? It is not
available if hadoop2? If so, can we have a comment on the method to this
effect? The log is a little confusing. Suggest: "SHOULD_REPLICATE is not
available; this is a problem if we are running on hadoop3 (Its expected if
hadoop2)".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
