ndimiduk commented on a change in pull request #1464: HBASE-24150 Allow module 
tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#discussion_r406336835
 
 

 ##########
 File path: dev-support/hbase-personality.sh
 ##########
 @@ -140,7 +140,10 @@ function personality_modules
 
   clear_personality_queue
 
-  extra="-DHBasePatchProcess"
+  # At a few points, hbase modules can run their test suites in parallel
 
 Review comment:
   Not just parallel test suites, but everything. With this change, maven will 
run up to 2 concurrent modules when the dependency graph permits. I imaging 
this will be a nice general benefit.
   
   One thing to note though is that some plugins don't support multithreading. 
IIRC, surefire-reports was one such plugin, and would print warnings in the 
build. Looks like this patch didn't actually trigger any maven invocation, so I 
cannot point you at the message. A simple `mvn clean package -DskipTests` 
should be enough to get the message printed.
   
   Since we use Jenkins to aggregate test results, I suggest we disable/remove 
surefire-reports (this was something I discussed with @busbey sometime back, 
but neither of us have gotten to it).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to