ndimiduk commented on a change in pull request #1464: HBASE-24150 Allow module 
tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#discussion_r406368419
 
 

 ##########
 File path: dev-support/hbase-personality.sh
 ##########
 @@ -140,7 +140,10 @@ function personality_modules
 
   clear_personality_queue
 
-  extra="-DHBasePatchProcess"
+  # At a few points, hbase modules can run their test suites in parallel
 
 Review comment:
   Yeah that's the plugin. Weirdly, now I try but I don't see the warning 
message. Hmm..
   
   Running with `-T1.0C` I get a failure in
   
   ```
   [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (check-aggregate-license) 
@ hbase-shaded-client ---                                                       
                                                    
   [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed 
with message:                                                                   
                                                   
   Couldn't evaluate condition: File license = new 
File("/Users/ndimiduk/repos/apache/hbase/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE");
                                                                                
                                                                                
                                                                             
                       // Beanshell does not support try-with-resources,        
                           
                       // so we must close this scanner manually                
                                                                                
                                                   
                       Scanner scanner = new Scanner(license);                  
                                                                                
                                                   
                                                                                
                                                                                
                                                   
                       while (scanner.hasNextLine()) {                          
                                                                                
                                                   
                         if (scanner.nextLine().startsWith("ERROR:")) {         
                                                                                
                                                   
                           scanner.close();                                     
                                                                                
                                                   
                           return false;                                        
                                                                                
                                                   
                         }                                                      
                                                                                
                                                   
                       }                                                        
                                                                                
                                                   
                       scanner.close();                                         
                                                                                
                                                   
                       return true;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to