virajjasani commented on a change in pull request #1512: HBASE-24186: 
RegionMover ignores replicationId
URL: https://github.com/apache/hbase/pull/1512#discussion_r408840105
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java
 ##########
 @@ -755,7 +755,8 @@ private ServerName getServerNameForRegion(RegionInfo 
region) throws IOException
       return null;
     }
     HRegionLocation loc =
-      
conn.getRegionLocator(region.getTable()).getRegionLocation(region.getStartKey(),
 true);
+      
conn.getRegionLocator(region.getTable()).getRegionLocation(region.getStartKey(),
 
 Review comment:
   It's great that IT test found this issue but they are not run as part of QA 
build. Hence, if we can have one unit test, that would be really great. QA will 
always run it. Sounds good @BukrosSzabolcs ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to